fix: EXPOSED-301 Update with join throws if additionalConstraint provided #2007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ided Attempting to use any join function in its full overload form, with an additionalConstraint argument, results in an exception if an update() is called instead of a select(). This occurs because the additionalConstraint conditions are being correctly appended to generated SQL, but their arguments are not being first registered with the prepared update statement. The arguments in the update statement now correctly register any additionalConstraint and take into account their order if an update with where is called.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to use any
joinfunction in its full overload form, with anadditionalConstraintargument, results in an exception if anupdate()is called after instead of aselect(), for example:This occurs because the
additionalConstraintconditions are being correctly appended to generated SQL, but their arguments are not being first registered with the prepared update statement.The arguments in the update statement now correctly register any
additionalConstraintand take into account their order if an update with a WHERE clause is called.No unit tests existed for the full overload form with
update(), so they have been added to existing tests.